Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept on higher build Java version #40025

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alzimmermsft
Copy link
Member

Description

Proof of concept for having a higher JVM build requirement than bytecode requirement. This PR increases the build requirement to Java 11 to enable support for newer version of Checkstyle and Spotless which now require a Java 11 runtime. This does NOT change baseline support requirements; those continue to be Java 8. If running build with Java 8 Checkstyle and Spotless won't run but will run in CI, preventing issues if testing locally with Java 8 and preventing code from being checked in with invalid Checkstyle or Spotless linting.

This only affects libraries using azure-client-sdk-parent as the parent POM, those using azure-data-sdk-parent will continue running linting when running on Java 8 as those libraries have a lower baseline support version (and are generally not in active development or are end of life).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this May 3, 2024
@github-actions github-actions bot added Azure SDK Tools Label for tracking issues related to Azure SDK Tools azure-spring All azure-spring related issues Azure.Core azure-core Azure.Core.AMQP azure-core-amqp OpenTelemetry OpenTelemetry instrumentation labels May 3, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core.AMQP azure-core-amqp Azure.Core azure-core Azure SDK Tools Label for tracking issues related to Azure SDK Tools azure-spring All azure-spring related issues OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants