[Text Translation] Updating to the latest TypeSpec #40035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeyMCZ
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova and
JonathanGiles
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
srnagar
reviewed
May 6, 2024
...translation-text/src/main/java/com/azure/ai/translation/text/TextTranslationAsyncClient.java
Outdated
Show resolved
Hide resolved
...translation-text/src/main/java/com/azure/ai/translation/text/TextTranslationAsyncClient.java
Show resolved
Hide resolved
...translation-text/src/main/java/com/azure/ai/translation/text/TextTranslationAsyncClient.java
Outdated
Show resolved
Hide resolved
MikeyMCZ
requested review from
alzimmermsft,
samvaity,
g2vinay and
JimSuplizio
as code owners
srnagar
reviewed
May 16, 2024
| String clientTraceId, String from, TextType textType, String category, ProfanityAction profanityAction, | ||
| ProfanityMarker profanityMarker, Boolean includeAlignment, Boolean includeSentenceLength, String suggestedFrom, | ||
| String fromScript, String toScript, Boolean allowFallback) { | ||
| private Mono<List<TranslatedTextItem>> translate(List<String> targetLanguages, List<InputTextItem> body, |
There was a problem hiding this comment.
nit: instead of body can we name the param inputTexts on all these APIs?
There was a problem hiding this comment.
My understanding is that it would require TypeSpec change as some parameters named body are in generated methods. I can change not generated, but then it will not be consistent.
...translation-text/src/main/java/com/azure/ai/translation/text/TextTranslationAsyncClient.java
Show resolved
Hide resolved
...translation-text/src/main/java/com/azure/ai/translation/text/TextTranslationAsyncClient.java
Outdated
Show resolved
Hide resolved
...translation-text/src/main/java/com/azure/ai/translation/text/TextTranslationAsyncClient.java
Outdated
Show resolved
Hide resolved
...translation-text/src/main/java/com/azure/ai/translation/text/TextTranslationAsyncClient.java
Outdated
Show resolved
Hide resolved
...anslation-text/src/main/java/com/azure/ai/translation/text/TextTranslationClientBuilder.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
May 17, 2024
...-ai-translation-text/src/main/java/com/azure/ai/translation/text/models/TranslationText.java
Outdated
Show resolved
Hide resolved
...ranslation-text/src/main/java/com/azure/ai/translation/text/models/TransliterableScript.java
Outdated
Show resolved
Hide resolved
added 3 commits
May 17, 2024 07:34
srnagar
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description