Skip to content

Commit

Permalink
Fix dependencies for @typescript-eslint/eslint-plugin (#4327)
Browse files Browse the repository at this point in the history
- @typescript-eslint/eslint-plugin@1.12.0 introduced an implicit dependency on @typescript-eslint/typescript-estree
  - This should be fixed in a future release of @typescript-eslint/eslint-plugin
  - typescript-eslint/typescript-eslint#705
  • Loading branch information
mikeharder committed Jul 16, 2019
1 parent ef2b4e6 commit 7c7e810
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 29 deletions.
54 changes: 27 additions & 27 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions common/config/rush/pnpmfile.js
@@ -1,4 +1,4 @@
"use strict";
'use strict';

/**
* When using the PNPM package manager, you can use pnpmfile.js to workaround
Expand Down Expand Up @@ -28,12 +28,20 @@ module.exports = {
* The return value is the updated object.
*/
function readPackage(packageJson, context) {

// // The karma types have a missing dependency on typings from the log4js package.
// if (packageJson.name === '@types/karma') {
// context.log('Fixed up dependencies for @types/karma');
// packageJson.dependencies['log4js'] = '0.6.38';
// }

// @typescript-eslint/eslint-plugin@1.12.0 introduced an implicit dependency on @typescript-eslint/typescript-estree.
// This should be fixed in a future release of @typescript-eslint/eslint-plugin.
// https://github.com/typescript-eslint/typescript-eslint/issues/705
if (packageJson.name === '@typescript-eslint/eslint-plugin') {
context.log('Fixed up dependencies for @typescript-eslint/eslint-plugin');
packageJson.dependencies['@typescript-eslint/typescript-estree'] =
'^1.11.0';
}

return packageJson;
}

0 comments on commit 7c7e810

Please sign in to comment.