Skip to content

Commit

Permalink
Revert "Fix dependencies for @typescript-eslint/eslint-plugin (#4327)" (
Browse files Browse the repository at this point in the history
#4390)

- @typescript-eslint/eslint-plugin@1.12.0 introduced an implicit dependency on @typescript-eslint/typescript-estree
- Fixed in @typescript-eslint/eslint-plugin@1.13.0
- typescript-eslint/typescript-eslint#705
  • Loading branch information
mikeharder committed Jul 23, 2019
1 parent 8086331 commit e80c96e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions common/config/rush/pnpmfile.js
Expand Up @@ -34,14 +34,5 @@ function readPackage(packageJson, context) {
// packageJson.dependencies['log4js'] = '0.6.38';
// }

// @typescript-eslint/eslint-plugin@1.12.0 introduced an implicit dependency on @typescript-eslint/typescript-estree.
// This should be fixed in a future release of @typescript-eslint/eslint-plugin.
// https://github.com/typescript-eslint/typescript-eslint/issues/705
if (packageJson.name === '@typescript-eslint/eslint-plugin') {
context.log('Fixed up dependencies for @typescript-eslint/eslint-plugin');
packageJson.dependencies['@typescript-eslint/typescript-estree'] =
'^1.11.0';
}

return packageJson;
}

0 comments on commit e80c96e

Please sign in to comment.