Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Registry] Debug #10602 #10683

Closed
wants to merge 6 commits into from

Conversation

HarshaNalluru
Copy link
Member

#10602 (comment)

Browser tests failing in the CI, but not on the local!!

@HarshaNalluru
Copy link
Member Author

@HarshaNalluru
Copy link
Member Author

It fails in the CI because it is on latest master.
If pulled the changes from master, the issue could be repro-ed locally.

That being said, there have been some dependency updates that were checked-in recently which might have broken things, I'll be looking to find which commit had regressions.

@HarshaNalluru
Copy link
Member Author

Summarizing the investigation and the fix for future reference:

With a binary search from the recent commits(Precisely, from 71e8c01 to 578c799) narrowed down to this commit 03db02d that broke things.

It has changes to @azure/core-http and @azure/identity which have modified the requests being made.
Since the branch was not in sync with master... it couldn't get those changes which would have changed the recordings.

The requests in the browser tests were relying on those changes and hence couldn't match with the ones saved in the recordings.

The fix was to pull master, regenerate the recordings, push them.

@HarshaNalluru
Copy link
Member Author

This investigation has also uncovered a bug in core-http introduced at 03db02d, which is being fixed by @sadasant at #10692

@nguerrera
Copy link
Contributor

Thanks again, @HarshaNalluru for all of your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants