Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Update live test command for storage packages #2616

Merged
merged 4 commits into from
May 2, 2019
Merged

[Storage] Update live test command for storage packages #2616

merged 4 commits into from
May 2, 2019

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented May 1, 2019 •
edited

@bsiegel

In #2047 - 128c033,

image
is updated to
image

Description

  • Nightly tests for storage-packages failed because build:test command wasn't executed.
  • This PR attempts to fix the nightly test runs by updating the "unit-browser" command to include "build:test".
  • [Storage] Rollup for tests in storage #2297 involves rollup for the tests in storage-packages, I will be updating the "scripts" section in the package.json to stay more consistent with the current package.json of servicebus/eventhubs(either in the same PR or in a follow-up PR).

@HarshaNalluru HarshaNalluru self-assigned this May 1, 2019
@HarshaNalluru HarshaNalluru added the Storage Storage Service (Queues, Blobs, Files) label May 1, 2019
@bsiegel
Copy link
Member

bsiegel commented May 1, 2019

This is fine for now - I am refactoring how the test commands are split out in a PR right now though, and once we have that landed it will fix this problem.

bsiegel
bsiegel approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍✨Ship It✨:shipit:

@HarshaNalluru HarshaNalluru merged commit 6d48236 into Azure:master May 2, 2019
@HarshaNalluru HarshaNalluru deleted the UpdateTestCommand branch May 2, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsiegel bsiegel bsiegel approved these changes

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

Assignees

@HarshaNalluru HarshaNalluru

Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HarshaNalluru @bsiegel