Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Fix NYC code coverage breaking changes in 14.0.0 #2627

Merged
merged 1 commit into from
May 1, 2019

Conversation

HarshaNalluru
Copy link
Member

@mikeharder
This PR attempts to fix improper functioning of nyc
nyc code coverage is not working after the update from ^13.3.0 to ^14.0.0 [ #2270 ]

[Breaking Change in 14.0.0]
https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md
https://github.com/istanbuljs/nyc#source-map-support-for-pre-instrumented-codebases

More reference - #2297 (comment)

@HarshaNalluru HarshaNalluru self-assigned this May 1, 2019
@HarshaNalluru HarshaNalluru added the Client This issue points to a problem in the data-plane of the library. label May 1, 2019
@HarshaNalluru HarshaNalluru merged commit 95b5e70 into Azure:master May 1, 2019
@ramya-rao-a
Copy link
Contributor

@HarshaNalluru Good find!
Can you update the nyc usage that is done in storage, event hubs, eph and amqp-common as well?

@HarshaNalluru
Copy link
Member Author

For storage, I'm doing it as part of my PR for Rollup (waiting for review #2297).
I can make PR for the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants