[Azure Monitor OpenTelemetry Exporter] Capture Measurements when Creating Logs #29511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
hectorhdzg
reviewed
Apr 30, 2024
sdk/monitor/monitor-opentelemetry-exporter/src/utils/logUtils.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Apr 30, 2024
sdk/monitor/monitor-opentelemetry-exporter/src/utils/logUtils.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
Issues associated with this PR
microsoft/ApplicationInsights-node.js#1318
Describe the problem that is addressed by this PR
Previously measurements passed from the Application Insights 3.X SDK were not being populated on logs in the exporter. These should be populated from the log body and exported to breeze.
Are there test cases added in this PR? (If not, why?)
Yes, added a test case to ensure that when measurements exist in the log body field, they're populated on the final envelope.
Checklists