Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] vector search: Test PR for generating build #29649

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

[Cosmos] vector search: Test PR for generating build #29649

wants to merge 41 commits into from
+4,814 −1,275

Conversation

topshot99
Copy link
Contributor

Packages impacted by this PR

@azure/cosmos

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

topshot99 and others added 18 commits January 17, 2024 17:11
@topshot99 @mkhandelwal-123
Feature/ru based capping for fetch requests (#28273)
c09469f 
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
In the Node SDK, when performing a cross-partition query and using the
FetchNext() method, the SDK will not return results until it has
retrieved the number of items specified by the maxItemCount in the query
options. This behaviour, while ensuring complete data retrieval, can
potentially lead to high consumption of Request Units (RU's) if the
dataset spans numerous partitions.
To address this issue, it is imperative to implement a mechanism that
allows for control over the number of RUs utilized per fetch operation,
whether it's via fetchNext() or fetchAll().

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
To enable Query operations to adhere to a Request Unit (RU) cap, we can
offer clients the option to specify the RU cap within the operation
options of fetch functions. When this cap is exceeded, clients will
receive an error notification.
For more details check this design docs:

https://microsoftapc-my.sharepoint.com/:w:/g/personal/abkolant_microsoft_com/EeWSsuBdil9PiSJ30xYGuK4B7J79hF0WwC3ZeuVtCb_fRg?e=s2MAuG

https://microsoftapc-my.sharepoint.com/:w:/g/personal/mkhandelwal_microsoft_com/EXLW5MXJagVHhLb0tjgpWl4BCBpm3CGHSzqWqRRlXAf5MQ?e=n4a43V

### Are there test cases added in this PR? (If not, why?)
yes

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
Feature/ru based capping for fetch requests (#28285)
804eb07 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
Feature/ru based capping for fetch requests (#28320)
14f032e 
### Packages impacted by this PR
@aure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
This PR addresses compatibility issues with certain browser environments
due to the disablement of SharedArrayBuffer.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123 @amanrao23
[Cosmos] Vector Search (#29621)
947f197 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
Co-authored-by: Aman Rao <amanrao@microsoft.com>
@amanrao23
Add NonStreamingOrderBy map class
3ca6c7a
@amanrao23
Fix fetchall for distinct value non streaming queries
af4656c
@amanrao23
fix nonStreamingOrderByMap
1072128
@amanrao23
Add test cases
17346ae
@amanrao23
Update tsconfig file
e069053
@amanrao23
refactor code
80ed457
@amanrao23
add NonStreamingDistinctOrderBy functional test
97b0d51
@amanrao23
Update test
fba5b5d
@amanrao23
Update Feed option field metadata
a07e483
@amanrao23
remove unrelated constants
30e26f5
@amanrao23
fix vector result buffer size calculation
fb00851
@amanrao23
check if vectorSearchBufferSize > 0
7c5f4d2
@amanrao23
Add distinct query tests
c681329
@topshot99 @mkhandelwal-123
remove comments (#29648)
5a7e100 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@github-actions github-actions bot added the Cosmos label May 9, 2024
@amanrao23
Copy link
Member

/az run

amanrao23 and others added 3 commits May 16, 2024 11:50
@amanrao23
Update tests
924fbf3
@topshot99 @mkhandelwal-123
Preview feat cosmosdb ru cap+vector search (#29714)
11ccd14 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
Preview feat cosmosdb ru cap+vector search (#29715)
feb4310 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
Test - Upgrade rush version (#29720)
0b2a33e 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
Preview feat cosmosdb ru cap+vector search (#29723)
acb3b30 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 topshot99 requested review from KarishmaGhiya, schaabs and a team as code owners May 16, 2024 14:58
amanrao23 and others added 11 commits May 16, 2024 22:01
@amanrao23
update emulator and tests
1503366
@topshot99 @mkhandelwal-123
version upgrade msal-node-extensions (#29726)
fb79762 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
[Test] update identity package package.json (#29729)
286ec9b 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
Update tests with flag (#29731)
a8ec112 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@amanrao23
update emulator and tests
5f80baa
@amanrao23
Merge branch 'preview-feat-cosmosdb-RU-Cap+Vector-Search' of https://…
7fd946b 
…github.com/Azure/azure-sdk-for-js into new-vector-search
@amanrao23
revert pnpm changes
50268bb
@amanrao23
fix tests
5e12677
@topshot99 @mkhandelwal-123
update documentation for vector embedding policy (#29739)
21be8e0 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
Update use-node-test-version.yml (#29742)
88f209c 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@topshot99 @mkhandelwal-123
update use-test-node-version.yml (#29743)
25a8c3d 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar kushagraThapar is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@simorenoh simorenoh Awaiting requested review from simorenoh simorenoh is a code owner

@v1k1 v1k1 Awaiting requested review from v1k1 v1k1 is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

@schaabs schaabs Awaiting requested review from schaabs

@joshfree joshfree Awaiting requested review from joshfree joshfree was automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck was automatically assigned from Azure/azure-sdk-write-identity

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie was automatically assigned from Azure/azure-sdk-write-identity

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@topshot99 @amanrao23