[engsys] upgrade dev dependency eslint-plugin-markdown to ^5.0.0 #29697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The breaking change that impacts us is that now `typescript` and `javascript` code blocks in markdown files are maped to virtual files with `.ts` or `.js`, instead of `.typescript` or `.javascript` as previously in v4. This PR reacts to the change: - Add an overrides entry for `**/*.md/*.ts` because they now matches the files pattern of our first override. Previously they are not linted because of the old `.typescript` virtual file extension. Their `project` is set to `null` because they are not part of any project. They still are benefited from rules that doesn't require type checking.
jeremymeng
requested review from
ckairen,
deyaaeldeen,
mikeharder,
FlorianBorn71,
KarishmaGhiya,
maorleger,
schaabs,
a team,
miguhern and
akania
as code owners
|
API change check API changes are not detected in this pull request. |
maorleger
approved these changes
May 15, 2024
xirzec
approved these changes
May 15, 2024
|
Failure unrelated to linting. Analyze builds are passing. Going to override and merge. |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking change that impacts us is that now
typescriptandjavascriptcode blocks in markdown files are maped to virtual files with
.tsor.js,instead of
.typescriptor.javascriptas previously in v4.This PR reacts to the change:
**/*.md/*.tsbecause they now match the filespattern of our first overrides entry. Previously they are not linted because of
their old
.typescriptextension. Theirprojectis set tonullas theydon't belong to any project. They still are benefited from rules that don't
require type checking.