Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup-plugin-node-resolve to 5.0.1 #3761

Closed

Conversation

mikeharder
Copy link
Member

This PR updates dev dependency rollup-plugin-node-resolve from ^4.2.0 to ^5.0.1 (current latest). This is a precursor to a future PR which will update rollup-plugin-node-resolve again, after rollup/rollup-plugin-node-resolve#223 is merged.

This PR was generated by running the following command:

cd sdk\servicebus\service-bus
rush add -p rollup-plugin-node-resolve@5.0.1 --dev --caret --make-consistent

There are two meaningful changes:

  • In all impacted package.json files, dev dependency rollup-plugin-node-resolve was updated from ^4.2.0 to ^5.0.1.
  • pnpm-lock.yaml was updated to the latest matching versions of all floated packages

All other changes should just be re-arranging lines in package.json, which is done automatically by Rush. The diff should be much smaller for future package updates.

@bsiegel
Copy link
Member

bsiegel commented Jun 13, 2019

@KarishmaGhiya we should exclude package.json from Prettier formatting since it will tend to conflict with Rush in terms of how the file should be laid out.

@bsiegel
Copy link
Member

bsiegel commented Jun 13, 2019

@mikeharder looks like 5.0.2 is out with the fix, did you want to address that in a different PR or just update this one?

@mikeharder
Copy link
Member Author

@bsiegel: I want to merge this first to reduce risk, then a second PR for 5.0.2 and unpinning resolve.

@mikeharder
Copy link
Member Author

This PR is causing build breaks. I'm investigating.

@mikeharder
Copy link
Member Author

Closing and will re-open when all issues are fixed.

@mikeharder mikeharder closed this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants