Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting .net sdk #44100

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jmegha123
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. labels May 17, 2024
Copy link

Thank you for your contribution @jmegha123! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Network

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmegha123 :

Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@archerzz
Copy link
Member

FYI. Azure.ResourceManager.Network version 1.8.0 was not released. So, it's OK to update (not revert) the codes.

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurMa1978
Copy link
Member

@jmegha123 as a stable release, can you please add tests for all new operations?

@jmegha123
Copy link
Member Author

@jmegha123 as a stable release, can you please add tests for all new operations?

@ArthurMa1978
IMHO, This is simply a revert PR which doesn't need any unit test to be written. The ones which you are talking about seems to be long discussion between you and vertika gupta how and where unit tests needs to be written which can be done for future releases

@jmegha123
Copy link
Member Author

@jmegha123 Please update the API signature. See the error log: https://dev.azure.com/azure-sdk/public/_build/results?buildId=3797673&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f&l=1701

Done ran this command .\eng\scripts\Export-Api.ps1 network

@jmegha123
Copy link
Member Author

@jmegha123 :

Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

yes i think i joined the necessary group

@jsquire
Copy link
Member

jsquire commented May 22, 2024

@jmegha123 :
Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

yes i think i joined the necessary group

Permissions issues are confirmed to be resolved.

@ArthurMa1978: Will your team be owning/supporting this library going forward or do we need to have a CODEOWNERS entry with the correct contacts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants