-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting .net sdk #44100
base: main
Are you sure you want to change the base?
Reverting .net sdk #44100
Conversation
Thank you for your contribution @jmegha123! We will review the pull request and get back to you soon. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmegha123 Please update the API signature. See the error log: https://dev.azure.com/azure-sdk/public/_build/results?buildId=3797673&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f&l=1701
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmegha123 Please update the API signature. See the error log: https://dev.azure.com/azure-sdk/public/_build/results?buildId=3797673&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f&l=1701
@jmegha123 as a stable release, can you please add tests for all new operations? |
@ArthurMa1978 |
Done ran this command .\eng\scripts\Export-Api.ps1 network |
yes i think i joined the necessary group |
Permissions issues are confirmed to be resolved. @ArthurMa1978: Will your team be owning/supporting this library going forward or do we need to have a CODEOWNERS entry with the correct contacts? |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.