-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Moved Databricks removal into explicit removal (before RG) for managed resource removal #1872
fix: Moved Databricks removal into explicit removal (before RG) for managed resource removal #1872
Conversation
…ts.ps1 Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…ts.ps1 Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…hr/bicep-registry-modules into users/workflowRetire
feat: Added deployment removal workflow
…auses managed rgs to be removed too
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. Note This label was added as per ITA06. |
Note The "Type: AVM |
@@ -92,6 +92,7 @@ function Initialize-DeploymentRemoval { | |||
'Microsoft.Compute/virtualMachines', | |||
'Microsoft.VirtualMachineImages/imageTemplates', # Must be removed before their MSI | |||
'Microsoft.ManagedIdentity/userAssignedIdentities', | |||
'Microsoft.Databricks/workspaces', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried and failed hard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the pipeline failed? Or the RGs remained? My 3 tests so far worked, but each time the Databricks deployment itself had issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RG remained. Let's maybe see if the behavior changed and this workaround works now. If still not, as discussed, we can work on a custom post removal logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-running one last time in the hopes that it's not getting stuck on the dependency issue again - like for the last 4 times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't get around the issue during the deployment. Will close the PR for now
Description
Moved Databricks removal into explicit removal (before RG) for managed resource removal
Fixes #1581
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.