This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Use conditional compilation for tests #895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bege13mot <bege13mot@gmail.com>
|
|
Signed-off-by: bege13mot <bege13mot@gmail.com>
| @@ -0,0 +1,120 @@ | |||
| package pack | |||
There was a problem hiding this comment.
do we need a conditional build flag for windows, or is Go smart enough about the _windows filename that it implies the windows build tag? I recall reading about that somewhere...
There was a problem hiding this comment.
Hi @bacongobbler,
As I can understand if we try to build it on a windows machine, there is no need to specify window build tag.
(example: source_windows_amd64.go) where GOOS and GOARCH represent any known operating system and architecture values respectively, then the file is considered to have an implicit build constraint requiring those terms (in addition to any explicit constraints in the file).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/draft/issues/883