Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Fix panic when failing to push images #921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laozc
Copy link

@laozc laozc commented Jan 21, 2019

A panic might happen when the auth required by a repo is not set.
This is due to the program tries to write to a channel which might have been closed.

The current logic tries to use one channel for result and another channel for any possible errors.
However, when routine exists, the error might be written to the error channel
after both channels might have been closed.

I changed the code to use only one channel.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant