Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix nolint issues #341

Merged
merged 1 commit into from Nov 26, 2020
Merged

Fix nolint issues #341

merged 1 commit into from Nov 26, 2020

Conversation

theunrepentantgeek
Copy link
Member

Looks like we were not following the rules for how //nolint comments work, and a recent update to the linter means these now break the build.

I think the relevant PR is this one.

For reference:

  • The comment must start with //nolint (no space)
  • To suppress a specific linter, use a colon - //nolint:gosec
  • To provide additional information, follow it with another comment -
    //nolint:gosec // don't need cryptographic random numbers

@coveralls
Copy link

coveralls commented Nov 26, 2020

Coverage Status

Coverage increased (+19.2%) to 73.092% when pulling 174a937 on fix/lint-issues into 1c684b6 on master.

@theunrepentantgeek theunrepentantgeek merged commit 316d6f9 into master Nov 26, 2020
@theunrepentantgeek theunrepentantgeek deleted the fix/lint-issues branch November 26, 2020 03:02
@theunrepentantgeek theunrepentantgeek added this to In progress in CRD Code Generation via automation Nov 26, 2020
@theunrepentantgeek theunrepentantgeek moved this from In progress to Done in CRD Code Generation Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants