Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to react 18 #124

Merged
merged 1 commit into from Aug 9, 2022
Merged

Conversation

yulinscottkang
Copy link
Contributor

@yulinscottkang yulinscottkang commented Aug 2, 2022

  • Add .prettierrc for a consistent formatting
  • Use conventional config for commitlint since chore is missing from the angular config
  • Upgrade devDependencies to react 18
  • Update peerDependencies to support react 18
  • Delete @testing-library/react-hooks since renderHook is now included in @testing-library/react (ref)
  • Fix AzureMapContext.test.tsx by wrapping component updates in act()
  • Update types.ts for react 18 (ref)
    • StatelessComponent -> FunctionComponent
    • IAzureMapFeature -> (IAzureMapFeature & ReactNode)

@rvdkooy
Copy link

rvdkooy commented Aug 6, 2022

Hi, does this work well with react 18 strict mode?
I tried this myself a whille ago and I remember running into some issues with it.
something in the line of: Uncaught Error: 'datasource-id' is already added to the map

it seems like not everything is being cleaned up after unmounting and then throws (which is the whole purpose of strictmode)

maybe I can help out a bit on this....

@yulinscottkang
Copy link
Contributor Author

Hi, does this work well with react 18 strict mode? I tried this myself a whille ago and I remember running into some issues with it. something in the line of: Uncaught Error: 'datasource-id' is already added to the map

it seems like not everything is being cleaned up after unmounting and then throws (which is the whole purpose of strictmode)

maybe I can help out a bit on this....

Hi @rvdkooy, this PR doesn't fix and modify anything related to strict mode. It would be great if you could provide help or elaborate on the issue, thanks!

@yulinscottkang yulinscottkang merged commit b35ab03 into Azure:master Aug 9, 2022
@rvdkooy
Copy link

rvdkooy commented Aug 10, 2022

Hi @yulinscottkang
I will look into this and see what is needed for this
thanks

@rvdkooy
Copy link

rvdkooy commented Aug 12, 2022

@yulinscottkang see: #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants