Add node function app examples. #113
Conversation
| @@ -0,0 +1,114 @@ | |||
| data "azurerm_subscription" "current" {} | |||
There was a problem hiding this comment.
I've seen this 201-function-app-key-vault-ref in #114, is this by intention or by mistake?
There was a problem hiding this comment.
removed the folder, this is my mistake.
| } | ||
|
|
||
| resource "azurerm_service_plan" "default_linux" { | ||
| name = "${var.name_prefix}-sp" |
There was a problem hiding this comment.
I've met a name collision due to declaring two azurerm_service_plan with the same name when I try to apply this module, please assign different names for these two plans, thanks.
| } | ||
|
|
||
| resource "azurerm_service_plan" "default_windows" { | ||
| name = "${var.name_prefix}-sp" |
There was a problem hiding this comment.
I've met a name collision due to declaring two azurerm_service_plan with the same name when I try to apply this module, please assign different names for these two plans, thanks.
|
|
||
| # Please use application_stack in site_config to set the node version, instead of specifying the WEBSITE_NODE_DEFAULT_VERSION under app_setting block. Terraform provider will handle the app_setting and set the necessary node runtime keys such as FUNCTIONS_EXTENSION_VERSION and WEBSITE_NODE_DEFAULT_VERSION. | ||
| resource "azurerm_linux_function_app" "default" { | ||
| name = "${var.name_prefix}-fa" |
There was a problem hiding this comment.
Same issue as the azurerm_service_plan, we'll meet name collision even these two function apps have different types. Please assign different names for these two function apps, thanks.
| } | ||
|
|
||
| resource "azurerm_windows_function_app" "default" { | ||
| name = "${var.name_prefix}-fa" |
No description provided.