Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 201-function-app #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lonegunmanb
Copy link
Member

No description provided.

@lonegunmanb lonegunmanb temporarily deployed to acctests March 27, 2023 02:17 — with GitHub Actions Inactive
Copy link
Contributor

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@@ -4,7 +4,7 @@ resource "azurerm_resource_group" "default" {
}

resource "azurerm_storage_account" "default" {
name = "${replace(random_pet.prefix.id, "-", "")}sa"
name = "${substr(replace(random_pet.prefix.id, "-", ""), 0, 22)}sa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why the function change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grayzu:

I believe @lonegunmanb is truncating the storage name so that it complies with the restrictions placed on Azure storage names.

@lonegunmanb lonegunmanb added this to Draft in User Story Review May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants