User Story 208753 - App Service Backup #316
Conversation
TomArcherMsft
had a problem deploying
to
acctests
GitHub Actions
Failure
TomArcherMsft
temporarily deployed
to
acctests
GitHub Actions
Inactive
TomArcherMsft
changed the title
There was a problem hiding this comment.
Thanks @TomArcherMsft for opening this pr! One comment and one question.
| file = false | ||
| } | ||
|
|
||
| start = "2024-01-01" |
There was a problem hiding this comment.
Would this hard code date be invalid from next year? Could we try formatdate("YYYY-MM-DD", timestamp()) for start, and formatdate("YYYY-MM-DD", timeadd(timestamp(), "8765h")) for expire, and add a comment to tell the reader, this dynamic date is only for testing purpose, please do not follow in the production environment?
|
|
||
| backup { | ||
| name = "Example" | ||
| storage_account_url = "https://${azurerm_storage_account.example.name}.blob.core.windows.net/${azurerm_storage_container.example.name}${data.azurerm_storage_account_sas.example.sas}&sr=b" |
There was a problem hiding this comment.
A question: I saw there's a question mark as delimiter in the url here, do we need a delimiter after ${azurerm_storage_container.example.name}?
There was a problem hiding this comment.
@ms-henglu This PR comes from your batch of samples. Could you please reply to Zijie about the delimiter and let me know what I need to change? Thanks.
There was a problem hiding this comment.
Hi @TomArcherMsft , would you please share me the link of my samples? So I could help investigate. Thanks!
|
@TomArcherMsft are you still planning on working on this one? Saw it on our backlog. |
@stemaMSFT Yes, I'm working on it now. Thanks for checking! |
User Story 208753