Setting theme for Ntlm dialog #2266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we currently forcing only text or background color? Dialog theme should be determined by the app, but it's weird for the text to be white-on-white (or black-on-black). |
Forcing text to be black and window background color to be white (updated description). We've gotten at least two incidents in the past regarding a white-on-white issue in the edittext, both on Teams devices iirc. I can't say I'm totally sure that this theme will fix the issue, but it should at least bring some consistency to the dialog. |
shahzaibj
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've received various issues regarding the text in the Ntlm dialog being invisible on certain Teams devices.
From some of my debugging, it seems that the dialog will inherit the styling of the host app. In an effort to help resolve these issues and to help keep the styling consistent, this PR creates and enforces a theme upon the Ntlm dialog that hardcodes the text to be black and the background of the dialog window to be white.
I verified that the dialog theme is consistent among three of our test apps, and loaded a site that invokes a test http auth request (https://www.httpwatch.com/httpgallery/authentication/) for testing.