Support for multiple tokens in native auth flows #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyO
reviewed
Apr 19, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Outdated
Show resolved
Hide resolved
SammyO
reviewed
Apr 30, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Outdated
Show resolved
Hide resolved
SammyO
reviewed
Apr 30, 2024
common4j/src/main/com/microsoft/identity/common/java/controllers/BaseController.java
Outdated
Show resolved
Hide resolved
rmccahill
reviewed
May 3, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Outdated
Show resolved
Hide resolved
rmccahill
reviewed
May 3, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Outdated
Show resolved
Hide resolved
rmccahill
reviewed
May 3, 2024
...y/common/java/nativeauth/commands/parameters/AcquireTokenNoFixedScopesCommandParameters.java
Outdated
Show resolved
Hide resolved
SammyO
reviewed
May 7, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Outdated
Show resolved
Hide resolved
SammyO
requested changes
May 8, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/BaseNativeAuthController.kt
Show resolved
Hide resolved
rmccahill
approved these changes
May 8, 2024
SammyO
changed the title
|
@SaurabhMSFT can you add a change log? |
SammyO
requested changes
May 15, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Outdated
Show resolved
Hide resolved
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Show resolved
Hide resolved
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Show resolved
Hide resolved
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Show resolved
Hide resolved
common4j/src/main/com/microsoft/identity/common/java/controllers/BaseController.java
Outdated
Show resolved
Hide resolved
SaurabhMSFT
added
the
Skip-Consumers-Check
SammyO
reviewed
May 17, 2024
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
Show resolved
Hide resolved
SammyO
reviewed
May 23, 2024
common4j/src/main/com/microsoft/identity/common/java/controllers/BaseController.java
Outdated
Show resolved
Hide resolved
SammyO
approved these changes
May 23, 2024
SaurabhMSFT
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
May 23, 2024
This PR and its companion PR (AzureAD/microsoft-authentication-library-common-for-android#2390) enables multiple access token support for Native Auth. A pair of new method have been added in the AccountState class to allow developer to retrieve different access tokens according to the requested scopes. The way these methods acquire tokens is exactly as same as the one in MSAL. The old method 'getAccessToken''s functionality hasn't been changed. It still returns the access token matching the default OIDC scope. This method though has been deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR and its companion PR (AzureAD/microsoft-authentication-library-for-android#2082) enables multiple access token support for Native Auth. A pair of new method have been added in the AccountState class to allow developer to retrieve different access tokens according to the requested scopes. The way these methods acquire tokens is exactly as same as the one in MSAL. The old method 'getAccessToken''s functionality hasn't been changed. It still returns the access token matching the default OIDC scope. This method though has been deprecated.
Two classes that have become unused have been removed.