Lozensky/enable managed identity #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zureAD/microsoft-identity-web into lozensky/EnableManagedIdentity
jennyf19
reviewed
Jan 25, 2024
tests/Microsoft.Identity.Web.Test/TokenAcquisitionAuthorityTests.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jan 25, 2024
src/Microsoft.Identity.Web.TokenAcquisition/DefaultAuthorizationHeaderProvider.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jan 25, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisitionOptions.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 25, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 25, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 25, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 25, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 25, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
requested changes
Jan 25, 2024
jmprieur
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
LGTM.
Nice job, @JoshLozensky !
- I've the same question as Jenny for the TokenAcquisitionOptions. Let's do simple!
- Please add .zip to the .gitignore file: we really don't want to add zips of Mb to the repo, which we'll never look at!
src/Microsoft.Identity.Web.TokenAcquisition/DefaultAuthorizationHeaderProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.ManagedIdentity.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.ManagedIdentity.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jan 26, 2024
...ationTests/PlaywrightTraces/B2CWebAppCallsWebApiLocally_TodoAppFunctionsCorrectly_net6.0.zip
Outdated
Show resolved
Hide resolved
keegan-caruso
requested changes
Jan 26, 2024
jmprieur
approved these changes
Jan 27, 2024
jennyf19
reviewed
Jan 27, 2024
jennyf19
reviewed
Jan 27, 2024
src/Microsoft.Identity.Web.TokenAcquisition/DefaultAuthorizationHeaderProvider.cs
Show resolved
Hide resolved
jennyf19
reviewed
Jan 27, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.ManagedIdentity.cs
Show resolved
Hide resolved
jennyf19
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Very nice work @JoshLozensky Looking forward to getting this out to customers very soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for managed identities
Summary of the changes (Less than 80 chars)
Added logic to default to managed identity credentials if available.
Description
In TokenAquisition.GetAuthenticationResultForAppAsync() added a check for managed identity configuration in the tokenAquisitionOptions parameter. If present, default to this authentication method and use system-assigned or user-assigned managed identity per the user's configuration.
Fixes #1775 #2551