Fixing some small bugs #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey James! Trust you're doing well!?
So... I'm no Python programmer, but I wanted to fix a few bugs that we found in the Slalom implementation. 馃榿
We're hitting the limits on some of these larger messages, and we also want to run it in a few channels (private team donuts, etc.)
Could you give me a hand validating the logic around breaking blocks into an array, from everything I've read it should work, but I can't test it locally, and I'm using VS Code in the browser to make these contributions.
I'll come back and do some double-checking on the "run once, for multiple channels" solution, but for now, this will help to resolve some issues in our current implementation.
Cheers,
Pat