Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include markdown readme in sphinx index #415

Merged
merged 17 commits into from Jul 13, 2021

Conversation

marscher
Copy link
Collaborator

@marscher marscher commented Jul 12, 2021

Changes

Include Readme and Changelog markdown files from repo root into the sphinx documentation. It uses the extension m2r2 which converts the Md files into rst.

Related Issues

Closes #406

Checks

  • updated doc/

@marscher marscher changed the title Inc readme in sphinx Include markdown readme in sphinx index Jul 12, 2021
@CagtayFabry CagtayFabry self-requested a review July 13, 2021 06:32
@CagtayFabry CagtayFabry added documentation Improvements or additions to documentation no-changelog-entry-needed labels Jul 13, 2021
@CagtayFabry CagtayFabry mentioned this pull request Jul 13, 2021
4 tasks
Copy link
Member

@CagtayFabry CagtayFabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧐

@marscher
Copy link
Collaborator Author

https://weldx--415.org.readthedocs.build/en/415/index.html The heading level of "Python API" should be the same as the ones in README.md.

And somehow the logo is not being displayed (firefox).

@marscher
Copy link
Collaborator Author

weldx--415.org.readthedocs.build-1626170700058.log
Seems like the logo is not shipped anymore.

@CagtayFabry CagtayFabry self-requested a review July 13, 2021 10:12
@CagtayFabry
Copy link
Member

weldx--415.org.readthedocs.build-1626170700058.log
Seems like the logo is not shipped anymore.

good catch !

@CagtayFabry
Copy link
Member

https://weldx--415.org.readthedocs.build/en/415/index.html The heading level of "Python API" should be the same as the ones in README.md.

And somehow the logo is not being displayed (firefox).

thought that was intended, I'll fix it
https://github.com/crossnox/m2r2#restrictions

@CagtayFabry
Copy link
Member

weldx--415.org.readthedocs.build-1626170700058.log
Seems like the logo is not shipped anymore.

good catch !

the logo does get shipped but somehow the link get's set to ..../_static/_static/WelDX_notext.svg instead of just ..../_static/WelDX_notext.svg as before..., might be an issue with the current pydata theme

@CagtayFabry
Copy link
Member

seems to be a sphinx issue introduced in 4.1, see sphinx-doc/sphinx#9438 sphinx-doc/sphinx#9381

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #415 (9e07760) into master (4c5c01c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          87       87           
  Lines        5352     5352           
=======================================
  Hits         5206     5206           
  Misses        146      146           
Impacted Files Coverage Δ
weldx/welding/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5c01c...9e07760. Read the comment docs.

@CagtayFabry CagtayFabry merged commit 047d699 into BAMWelDX:master Jul 13, 2021
@marscher marscher deleted the inc_readme_in_sphinx branch July 13, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy README.md contents to index.rst
2 participants