No interface if only one implementation

BBB · Jul 19, 2023 · b9b0350 · b9b0350
1 parent e7d7752
commit b9b0350
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 26 deletions.
diff --git a/src/main/kotlin/me/relph/application/Launcher.kt b/src/main/kotlin/me/relph/application/Launcher.kt
@@ -1,10 +1,10 @@
 package me.relph.application
 
-import me.relph.domain.hub.HubImpl
+import me.relph.domain.hub.Hub
 import me.relph.domain.adapter.InMemoryUserStorage
 
 fun main() {
-    val hub = HubImpl(InMemoryUserStorage())
+    val hub = Hub(InMemoryUserStorage())
     val server = HexHttpServer(hub)
 
     server.start()

diff --git a/src/main/kotlin/me/relph/domain/hub/Hub.kt b/src/main/kotlin/me/relph/domain/hub/Hub.kt
@@ -0,0 +1,12 @@
+package me.relph.domain.hub
+
+import dev.forkhandles.result4k.*
+import me.relph.domain.port.UserStorage
+
+typealias UserId = String
+
+class Hub(private val users: UserStorage)  {
+    fun greet(userId: UserId) = users.byId(userId).map{"hello ${it.name}"}.flatMapFailure { Success("hello anon") }
+    fun ping() = Success("pong")
+}
+
diff --git a/src/main/kotlin/me/relph/domain/hub/HubImpl.kt b/src/main/kotlin/me/relph/domain/hub/HubImpl.kt
diff --git a/src/main/kotlin/me/relph/domain/port/Hub.kt b/src/main/kotlin/me/relph/domain/port/Hub.kt
diff --git a/src/test/kotlin/me/relph/domain/hub/HubImplTest.kt b/src/test/kotlin/me/relph/domain/hub/HubImplTest.kt
@@ -9,7 +9,7 @@ import strikt.assertions.isEqualTo
 
 internal class HubImplTest {
 
-    private val hub = HubImpl(InMemoryUserStorage())
+    private val hub = Hub(InMemoryUserStorage())
 
     @Test
     fun `can ping`() {
@@ -19,4 +19,4 @@ internal class HubImplTest {
     fun `can greet an unknown user`() {
         expectThat(hub.greet("xxx")).isEqualTo(Success("hello anon"))
     }
-}
+}