allow copy of searchParams too

BBB · Nov 1, 2023 · c44f46a · c44f46a
1 parent da5eda0
commit c44f46a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/http-client/src/ImmutableURL.ts b/packages/http-client/src/ImmutableURL.ts
@@ -28,11 +28,15 @@ export class ImmutableURL implements Readonly<URL> {
     this.#searchParams = new ImmutableURLSearchParams(this.#url.searchParams);
   }
 
-  copy(update?: Partial<Pick<ImmutableURL, MutableURLFields>>) {
+  copy(
+    update?: Partial<Pick<ImmutableURL, MutableURLFields | "searchParams">>,
+  ) {
     const next = new URL(this.#url.toString());
     if (update) {
       Object.entries(update).forEach(([key, value]) => {
-        if (isMutableUrlField(key)) {
+        if (key === "searchParams") {
+          next.search = value.toString();
+        } else if (isMutableUrlField(key) && typeof value === "string") {
           next[key] = value;
         }
       });

diff --git a/packages/http-client/test/ImmutableURL.ts b/packages/http-client/test/ImmutableURL.ts
@@ -8,3 +8,14 @@ it("can copy the fields", () => {
   expect(underTest.password).not.toEqual(changed.password);
   expect(changed.toString()).toEqual("https://user:pass@example.com/api");
 });
+
+it("can copy using search params", () => {
+  const underTest = new ImmutableURL("https://example.com/api");
+  const changed = underTest.copy({
+    searchParams: underTest.searchParams.set("updated", "true"),
+  });
+  expect(underTest.searchParams).not.toEqual(changed.searchParams);
+  expect(underTest.search).not.toEqual(changed.search);
+  expect(changed.toString()).toEqual("https://example.com/api?updated=true");
+  expect(changed.search).toEqual("?updated=true");
+});