Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benchmarks with Criterion #31

Draft
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

Laifsyn
Copy link

@Laifsyn Laifsyn commented Apr 14, 2024

No description provided.

@Laifsyn Laifsyn mentioned this pull request Apr 14, 2024
@Laifsyn
Copy link
Author

Laifsyn commented Apr 14, 2024

This should probably be the snippet of interest

//8GB RAM 2-cores Codespace
English                 time:   [159.08 µs 161.34 µs 163.93 µs]
Found 14 outliers among 100 measurements (14.00%)
  4 (4.00%) high mild
  10 (10.00%) high severe

French                  time:   [157.37 µs 159.43 µs 161.73 µs]
Found 18 outliers among 100 measurements (18.00%)
  6 (6.00%) high mild
  12 (12.00%) high severe

French_BE               time:   [157.24 µs 159.91 µs 163.33 µs]
Found 16 outliers among 100 measurements (16.00%)
  3 (3.00%) high mild
  13 (13.00%) high severe

French_CH               time:   [157.60 µs 159.73 µs 162.13 µs]
Found 18 outliers among 100 measurements (18.00%)
  11 (11.00%) high mild
  7 (7.00%) high severe

Spanish                 time:   [17.792 µs 18.141 µs 18.551 µs]
Found 15 outliers among 100 measurements (15.00%)
  2 (2.00%) high mild
  13 (13.00%) high severe

Ukrainian               time:   [158.49 µs 160.56 µs 162.99 µs]
Found 19 outliers among 100 measurements (19.00%)
  6 (6.00%) high mild
  13 (13.00%) high severe

* Fix Tens edge case for Ordinals

based on [Real Academia Española](https://www.rae.es/dpd/ordinales) standards, the TENS of 2 have no space between itself and its units.
`"la primera y a la segunda decena se pueden escribir en una o en dos palabras, siendo hoy mayoritaria y siempre preferible la grafía univerbal"`

* Fix Ordinals Representation
From Ballasi#29 (comment),
fix ordinal representation based on the rules defined in 2.b && 2.d @
https://www.rae.es/dpd/ordinales

* Fix Tests & remove comments

* Currency Translation for spanish

* Cardinal Fix - Mistakenly used English semantics (#1)

Fix the wrong semantics that was used.
Spanish semantics follows this pattern of for each big milliard (Million, Billion, Trillion) grows at a pace of `1 000 000`^n

This means that 1 million is `1 000 000`^1
1 billion => `1 000 000`^2 [1 000_000 000_000]
1 trillion => `1 000 000`^3 [1 000_000 000_000 000_000]
1 quadrillion => `1 000 000`^4 [......]
...... etc

This semantic differs from english's
1 billion => `1 000`^3 [1 000 000_000] 
1 trillion => `1 000 000`^4 [1 000_000 000_000]
1 quadrillion => `1 000 000`^4 [......]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant