Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR Listener & HDR State Trigger #1262

Merged

Conversation

Ace-Radom
Copy link
Contributor

@Ace-Radom Ace-Radom commented Apr 26, 2024

Should close #1257.

Add a new HDRListener to watch HDR state changes, and two triggers HDROnAutomationPipelineTrigger & HDROffAutomationPipelineTrigger.

I set it to draft cuz there's still a problem needs to be solved. When I turn on HDR and then close the Lid (with an external monitor connected), there's about 50% chance that LLT crashes. Same thing happens when I open the Lid after that. It's most likely because of getting Display from InternalDisplay class, but I'm not sure yet.

Bug fix status update: it should be fixed in f441693, at least it didn't crash in the past four / five times on my device. Multi-devices test done.

Summary by CodeRabbit

  • New Features

    • Introduced HDR control features, enabling automation triggers based on HDR settings.
    • Added support for HDR automation triggers in the user interface with localized display names.
  • Bug Fixes

    • Improved equality check in a specific trigger for accurate behavior.
  • Documentation

    • Updated documentation with new environment variables indicating HDR status.

Copy link

coderabbitai bot commented Apr 26, 2024

Walkthrough

The recent updates to the Lenovo Legion Toolkit focus on enhancing HDR (High Dynamic Range) settings automation. New classes, interfaces, and resources have been added to enable actions triggered by changes in HDR status, like enabling or disabling HDR. These updates bring more customization options to users, especially regarding display settings.

Changes

Files Changes
.../Automation/AutomationEnvironment.cs
.../Automation/AutomationProcessor.cs
.../Automation/IAutomationEvent.cs
.../Automation/Pipeline/Triggers/...
.../Automation/Resources/...
Added support for HDR automation, introducing constants, properties, triggers, and resources.
.../Listeners/HDRListener.cs
.../IoCModule.cs
Introduced HDRListener class and its registration for monitoring HDR changes.
.../WPF/Windows/Automation/...
.../WPF/Extensions/...
Enhanced WPF components to accommodate HDR triggers in the user interface.
README.md
README_zh-hans.md
Updated documentation with new environment variables related to HDR status.

Assessment against linked issues

Objective Addressed Explanation
Implement HDR triggers for automation actions (#1257)
Ensure HDR settings are reflected in UI components (#1257)
Documentation of HDR related changes (#1257)

🐰✨
In the realm of code, where algorithms dance,
A rabbit weaved HDR into a trance.
Brightness soaring, HDR in its might,
Devs' hands crafting, a dazzling light!
Here's to the devs, their code so bright,
Illuminating screens, a wondrous sight! 🌟🖥️
🐰💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Ace-Radom Ace-Radom marked this pull request as ready for review April 27, 2024 06:57
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

if (Log.Instance.IsTraceEnabled)
Log.Instance.Trace($"Event received.");

Task.Delay(100).ContinueWith(_ =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this architecture both HDRListener and DisplayConfigurationListener are watching SystemEvents.DisplaySettingsChanged signal. The thing (which caused the unreliability before) is, HDRListener needs InternalDisplay class to get HDR state, but DisplayConfigurationListener calls InternalDisplay class to refresh, and they run in parallel. Normally, HDRListener gains the lock in InternalDisplay first and get what it needs, and then InternalDisplay will be set to refresh-needed, which causes the display api HDRListener got becomes null. Therefore I added this delay here, in order to let InternalDisplay set its state first.

@Ace-Radom
Copy link
Contributor Author

@BartoszCichecki should be done, ready for review

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bc4883d and d542eaf.
Files selected for processing (1)
  • LenovoLegionToolkit.Lib/IoCModule.cs (1 hunks)
Files skipped from review due to trivial changes (1)
  • LenovoLegionToolkit.Lib/IoCModule.cs

@Ace-Radom
Copy link
Contributor Author

@BartoszCichecki new commits merged. Would you plz review this PR in your spare time? (Only a reminder xD)

@BartoszCichecki
Copy link
Owner

Hey @Ace-Radom I haven't forgotten! The PR looks good, but I have been busy with Gen 9 stuff recently. I will merge this when I am done with that.

@BartoszCichecki BartoszCichecki changed the base branch from master to feat/hdr May 17, 2024 18:41
@BartoszCichecki BartoszCichecki merged commit 5b96b5d into BartoszCichecki:feat/hdr May 17, 2024
1 check passed
@Ace-Radom
Copy link
Contributor Author

Hey @Ace-Radom I haven't forgotten! The PR looks good, but I have been busy with Gen 9 stuff recently. I will merge this when I am done with that.

Thx for telling me this xD. Hope you will finish it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would be nice to have Actions triggered by enabling/disabling HDR.
2 participants