-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDR Listener & HDR State Trigger #1262
HDR Listener & HDR State Trigger #1262
Conversation
WalkthroughThe recent updates to the Lenovo Legion Toolkit focus on enhancing HDR (High Dynamic Range) settings automation. New classes, interfaces, and resources have been added to enable actions triggered by changes in HDR status, like enabling or disabling HDR. These updates bring more customization options to users, especially regarding display settings. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
LenovoLegionToolkit.Lib.Automation/Pipeline/Triggers/DisplayOffAutomationPipelineTrigger.cs
Show resolved
Hide resolved
LenovoLegionToolkit.Lib.Automation/Pipeline/Triggers/HDROnAutomationPipelineTrigger.cs
Show resolved
Hide resolved
LenovoLegionToolkit.Lib.Automation/Pipeline/Triggers/HDROffAutomationPipelineTrigger.cs
Show resolved
Hide resolved
if (Log.Instance.IsTraceEnabled) | ||
Log.Instance.Trace($"Event received."); | ||
|
||
Task.Delay(100).ContinueWith(_ => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this architecture both HDRListener
and DisplayConfigurationListener
are watching SystemEvents.DisplaySettingsChanged
signal. The thing (which caused the unreliability before) is, HDRListener
needs InternalDisplay
class to get HDR state, but DisplayConfigurationListener
calls InternalDisplay
class to refresh, and they run in parallel. Normally, HDRListener
gains the lock in InternalDisplay
first and get what it needs, and then InternalDisplay
will be set to refresh-needed, which causes the display api HDRListener
got becomes null. Therefore I added this delay here, in order to let InternalDisplay
set its state first.
@BartoszCichecki should be done, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- LenovoLegionToolkit.Lib/IoCModule.cs (1 hunks)
Files skipped from review due to trivial changes (1)
- LenovoLegionToolkit.Lib/IoCModule.cs
@BartoszCichecki new commits merged. Would you plz review this PR in your spare time? (Only a reminder xD) |
Hey @Ace-Radom I haven't forgotten! The PR looks good, but I have been busy with Gen 9 stuff recently. I will merge this when I am done with that. |
Thx for telling me this xD. Hope you will finish it soon. |
Should close #1257.
Add a new
HDRListener
to watch HDR state changes, and two triggersHDROnAutomationPipelineTrigger
&HDROffAutomationPipelineTrigger
.I set it to draft cuz there's still a problem needs to be solved. When I turn on HDR and then close the Lid (with an external monitor connected), there's about 50% chance that LLT crashes. Same thing happens when I open the Lid after that. It's most likely because of getting
Display
fromInternalDisplay
class,but I'm not sure yet.Bug fix status update: it should be fixed in f441693, at least it didn't crash in the past four / five times on my device. Multi-devices test done.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation