Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated libraries #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

NikasZalias
Copy link

Updated libraries, solution builds properly

@martijn00
Copy link
Member

It need to target Android 8 to work. Did you check if the samples are still working?

@NikasZalias
Copy link
Author

Yeah samples still worked as before.. Only horizontal scroll works, vertical still no good

@martijn00
Copy link
Member

Did you check the code to see if anything causes this bug?

@NikasZalias
Copy link
Author

Yeah, I tried to find something, but haven't found anything... still trying to figure it out, but since it's your code, maybe you could find it faster than me

@NikasZalias
Copy link
Author

@martijn00 Have you managed to find the bug??

@NikasZalias
Copy link
Author

@martijn00 I noticed that When I try to drag an item I get notified by this message "Start drag has been called but swiping is not enabled". But also I noticed that in RecyclerListAdapter class the overriden OnItemMove method is never called!

@NikasZalias
Copy link
Author

I finally made it work... In SimpleItemTouchHelperCallback class I made variable swipeEnabled = false. Now I can drag and drop normally! Of course in my case I don't need swiping so maybe you could update your nuget with possibility to turn on/off swiping or dragging??

@martijn00
Copy link
Member

Can you make a fix to add that?

@NikasZalias
Copy link
Author

Sorry.. after I posted last comment I saw that you actually can turn on/off drag or swipe.. so it's all good, but the problem is that when both are on you can't drag..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants