Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #436 - Evict on 404 and notify listeners #437

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ltOgt
Copy link

@ltOgt ltOgt commented Dec 5, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

⤵️ What is the current behavior?

  • On an existing cacheFile and 404 on the update, listeners are not notified of the 404, and the file is not evicted.

🆕 What is the new behavior (if this is a feature change)?

  • On 404 only, adds error to stream for existing cache file and evicts file

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Includes test

📝 Links to relevant issues/docs

#436

also see Baseflow/flutter_cached_network_image#898 for some related issues

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • ~~Relevant documentation was updated~~~
    • no documentation change needed
  • Rebased onto current develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant