New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AlignmentGeometry in constructor #27

Open

narumi147 wants to merge 1 commit into Baseflow:develop from narumi147:develop

narumi147 commented Nov 20, 2022

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

defined: final AlignmentGeometry alignment
In constructor: Alignment? alignment,

Event in the comment of alignment field, it said can be AlignmentDirectional but the constructor not allowed.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

All projects build
Follows style guide lines
Relevant documentation was updated
Rebased onto current develop


          Use AlignmentGeometry in constructor

b5c1066

Author

narumi147 commented Jan 6, 2023

@renefloor can you have a look? it's just a small change.

martijn00 requested a review from renefloor

October 17, 2023 15:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment