Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more Maven aliases #2191

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tomaytotomato
Copy link

@tomaytotomato tomaytotomato commented Feb 4, 2023

Description

Aliases for cleaning, packaging and testing only with Maven lifecycle.

Also added aliases to start stop Spring Boot, Quarkus, Micronaut and Jetty server

Motivation and Context

As a bash-it user I would like to have aliases for the following:

  • Running mvn package and mvn compile without test cycle
  • Running mvn test cycle independantly
  • Running common Java service frameworks like Spring Boot etc.

How Has This Been Tested?

  • Applied locally as custom aliases
  • Checked it does not clash with any other aliases
  • Ran a maven project using some aliases

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Aliases for testing only, skipping tests on Package and Compile lifecycles.

Also added aliases to start stop Spring Boot, Quarkus, Micronaut and Jetty server
Copy link
Member

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings and thanks for submitting the PR!

I left a few remarks - feel free to discuss.

Comment on lines 21 to 26
# Maven service plugin aliases
alias springrun='mvn spring-boot:run'
alias springstop='mvn spring-boot:stop'
alias jettyrun='mvn jetty:run'
alias quarkrun='mvn quarkus:dev'
alias microrun='mvn mn:run'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not loving these as general maven-centric aliases.
They seem a bit long, BUT if you put a leading m on them I could see keeping them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I have revised them and also removed springstop as most of the time it can be terminated from the terminal

@tomaytotomato
Copy link
Author

Not quite sure whats causing the tests to fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants