Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: file upload (minio, s3, frontend...) #443

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

feat: file upload (minio, s3, frontend...) #443

wants to merge 32 commits into from

Conversation

yoannfleurydev
Copy link
Member

@yoannfleurydev yoannfleurydev commented Jan 12, 2024 •
edited by ntatoud

Describe your changes

closes #<issue_id>

Simplified version of the Avatar Upload process :
image

Notes :

  • To upload a file in a different folder on the bucket, the path should be included in the key of the file

Left to do / Lines of thought

  •  (IN A FUTURE PR) How do we handle upload of sensitive files (i.e with restricted access) ? Because currently, the files uploaded are public and the url is permanent.
  • (IN A FUTURE PR) How do we keep track (on the server) of the different files uploaded ?
  • Summarize the existing logic for a better understanding
  • (IN A FUTURE PR) There is currently no way of deleting a file from the Frontend
  1. Simplify, clean and remove unused parts to get the existing part working and as simple as possible. (For know, just focus on public file upload for avatars and we'll see later for the rest.
  2. Rebase to get the React-hook-form update
  3. Update the fields
  4. Only leave what is necessary for upload an account avtar

Screenshots

Documentation

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files

@vercel Vercel
Copy link

vercel bot commented Jan 12, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ❌ Failed (Inspect) May 24, 2024 4:02pm

@yoannfleurydev yoannfleurydev mentioned this pull request Jan 12, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntatoud ntatoud force-pushed the feat/upload-files-minio-s3 branch from 0305a22 to 2ec53e9 Compare April 8, 2024 16:04
@ntatoud
Copy link
Contributor

ntatoud commented Apr 8, 2024

TODO :

  • Upload multiple files ??
  • Verify file types => Any file can be uploaded as an avatar
  • Maybe improve README with new modifications ?

@ntatoud ntatoud force-pushed the feat/upload-files-minio-s3 branch from bfda1a2 to 88c14de Compare May 6, 2024 13:15
@ntatoud
Copy link
Contributor

ntatoud commented May 6, 2024

Here is the idea for the refactor I did in commit : refactor(file-upload): Remove hook abstraction layer and regroup feature's files
…
image

DecampsRenan
DecampsRenan requested changes May 6, 2024
View reviewed changes
src/files/utils.ts Outdated Show resolved Hide resolved
src/files/utils.ts Outdated Show resolved Hide resolved
src/files/utils.ts Outdated Show resolved Hide resolved
src/server/config/s3.ts Outdated Show resolved Hide resolved
src/features/account/AccountProfileForm.tsx Show resolved Hide resolved
@ntatoud ntatoud force-pushed the feat/upload-files-minio-s3 branch from 4352848 to 48a85ea Compare May 13, 2024 10:37
@ntatoud ntatoud force-pushed the feat/upload-files-minio-s3 branch from 07a8868 to baf7bce Compare May 20, 2024 12:58
Fabien Essid and others added 21 commits May 23, 2024 16:50
@ntatoud
feat: add optional user metadata on signedUrl S3 calls
b10ac89
@hugperez @ntatoud
remove ACL, implement getSignedUrl, minio env variables
38b54d2
@ntatoud
feat: improve file uploads + useAvatarUpload and useFileUpload hooks
a1e5978
@ntatoud
fix: change POST http word by GET to get presigned urls
63b57df
@ntatoud
feat: fetch avatar in front-end to get metadata
a12bcec
@ntatoud
wip: FieldUploadPreview example in Storybook
a2de39a
@yoannfleurydev @ntatoud
fix: docker version minio and example order
06ea31a
@ntatoud
refactor(file-upload): Remove hook abstraction layer and regroup feat…
35638d2 
…ure's files
@ntatoud
fix(file-upload): Remove unused code to simplify
2fe8b59
@ntatoud
fix(file-upload): Feedback + more simplifcation
53c92aa
@ntatoud
wip: refactor(file-upload): with react-hook-form
86e63dc
@ntatoud
fix(file-upload): clean zod schema + file type validation
3592833
@ntatoud
docs(file-upload): Update docs.stories for RHF FieldUpload
c0f0f32
@ntatoud
test(file-upload): Vitest update and default value for FieldUpload
63ab483
@ntatoud
refactor(file-upload): move avatar file check before call to mutation
87751a2
@ntatoud
feat(file-upload): FieldUploadPreview with RHF
f0e86ec
@ntatoud
fix(file-upload): Delete previous Formiz FieldUpload
c4fa798
@ntatoud
fix(file-upload): remove control prop and defaultValues
5703d18
@ntatoud
fix(file-upload): Apply feedbacks
6195211
@ntatoud
fix: revert remove control props cause it breaks type safety
ff4fb98
@ntatoud
fix: sonar cloud code smells
e1fa6d3
@ntatoud ntatoud force-pushed the feat/upload-files-minio-s3 branch from 07aeb97 to e1fa6d3 Compare May 23, 2024 14:53
ivan-dalmet
ivan-dalmet requested changes May 24, 2024
View reviewed changes
Copy link
Member

@ivan-dalmet ivan-dalmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests are failing

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntatoud ntatoud ntatoud left review comments

@ivan-dalmet ivan-dalmet ivan-dalmet requested changes

@DecampsRenan DecampsRenan DecampsRenan approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yoannfleurydev @ntatoud @DecampsRenan @ivan-dalmet @hugperez