chore(deps): bump github.com/spf13/viper from 1.17.0 to 1.18.1 #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.17.0...v1.18.1) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Looks like it fixed the issue we had with Env variables in this PR spf13/viper#1429 so I added 3c28ec8 |
cfabianski
reviewed
Dec 11, 2023
| // viper.SetEnvKeyReplacer(replacer) | ||
| arguments := append( | ||
| []string{flag.ConfigName, strings.ToUpper("bearer_" + strings.ReplaceAll(flag.Name, "-", "_"))}, | ||
| flag.EnvironmentVariables..., |
There was a problem hiding this comment.
This is missing and needs adding back before merging
|
@didroe ready for another review |
didroe
approved these changes
Dec 12, 2023
cfabianski
deleted the
dependabot/go_modules/github.com/spf13/viper-1.18.1
branch
gotbadger
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/spf13/viper from 1.17.0 to 1.18.1.
Release notes
Sourced from github.com/spf13/viper's releases.
... (truncated)
Commits
fb6eb1efix: merge missing struct keys inside UnmarshalExactf5fcb4achore: update cryptf736363fix isPathShadowedInFlatMap type cast bug (#1585)36a3868Review changesf0c4ccdfix: gocritic lint issues3a23b80ci: enable test shuffle; fix tests73dfb94feat: make Unmarshal work with AutomaticEnv6ea31aerefactor: move all settings code to a getterc4dcd31fix: godot lint issues4c9b2a2Note Get* behavior on parse failureDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)