bowerphp can now handle the .bowerrc file put into the parents directories #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -250,4 +265,16 @@ protected function getHomeDir() | |||
|
|
|||
| return rtrim($home, '/'); | |||
| } | |||
|
|
|||
| protected function getBowerrcPath() | |||
There was a problem hiding this comment.
Can you please do the following?
- add a phpdoc block
- avoid do/while
- fix indent
There was a problem hiding this comment.
Yeah sure! I'll do it within a few days. Pretty busy right now. :-)
|
Still working on this? Otherwise I'll close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the bowerJS does, this PHP implementation can now get the config values from a bowerrc file placed into the current directory or the parent directories.