Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks/partially refactors small craft repair/refueling modules #2649

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

benbot16
Copy link
Contributor

About The Pull Request

This PR fixes several issues with fighter repair & refuelling modules, and fixes some bugs surrounding them.

Things changed:

  • Repair/refuel modules are a bit more sane now, and shouldn't arbitrarily stop fueling because of battery issues or the target not having any gas
  • Repair/refuel modules are a bit faster now (although they aren't quite as fast as doing things by hand)
  • Repair/refuel modules have a max range
  • Targeting has more signals
  • Dropship virtual z-levels are a bit more sane, and should stop making repair beams die

Why It's Good For The Game

This should hopefully make these modules more useful.
Also, runtimes bad.

Testing Photographs and Procedure

Screenshots&Videos

image

image

Changelog

🆑
tweak: Air-to-air repair/refuel modules now have a maximum range.
tweak: Adjusts repair/fuel transfer times for air-to-air modules
fix: Air-to-air repair/refuel modules now function properly.
fix: Fixes a virtual-z issue with dropships
/:cl:

@benbot16 benbot16 changed the title Tweaks/partially refactors small craft repair/refuelling modules Tweaks/partially refactors small craft repair/refueling modules May 13, 2024
@Bokkiewokkie Bokkiewokkie added Fix Tweak Overmap This issue or PR is related to overmap interactions Fighters Issues and pull requests related to fighters. labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Fighters Issues and pull requests related to fighters. Fix Overmap This issue or PR is related to overmap interactions Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants