Run behat fixture features against Cucumber parser #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To further document areas of difference with Cucumber, this uses the go binary releases to test that the AST produced by the real cucumber is the same as the AST behat produces
ciaranmcnulty
force-pushed
the
cucumber-parity-tests
branch
from
ee721b4
to
789ed5c
Compare
stof
reviewed
Mar 9, 2021
| @@ -118,7 +118,7 @@ private static function getBackground(array $json) | |||
| array_map( | |||
| static function ($child) { | |||
| return new BackgroundNode( | |||
| $child['background']['name'], | |||
| isset($child['background']['name']) ? $child['background']['name'] : null, | |||
There was a problem hiding this comment.
I just forgot what versions we support
There was a problem hiding this comment.
Well, you used ?? in the same diff a few lines below 😄
There was a problem hiding this comment.
I don't have a good memory :)
|
|
||
| if (isset($this->behatFeaturesCucumberCannotParseCorrectly[$ymlFile->getFilename()])){ | ||
| $this->markTestIncomplete($this->behatFeaturesCucumberCannotParseCorrectly[$ymlFile->getFilename()]); | ||
| return; |
There was a problem hiding this comment.
this return is dead code as markTestIncomplete never returns but always throws
| $newConfig = str_replace($oldTag, $newTag, $githubConfig); | ||
| file_put_contents($githubFile, $newConfig); | ||
|
|
||
| echo "Updated github build action:$newConfig\n"; |
There was a problem hiding this comment.
you should put a \n before the new config, to be more readable (otherwise, the first line of the config is stuck with the message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To further document areas of difference with Cucumber, this uses the go binary releases to test that the AST produced by the real cucumber is the same as the AST behat produces