alerts endpoint #119
Draft
alerts endpoint #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is an exploration into adding an endpoint for showing alerts. It has the possibility that we take it to feature complete in this PR, in separate stages, or scrap it even.
Progress
/alerts/*endpoint which handles all alerts (except for follows).onRaid()has been wired up. The other alerts still need to be wired up.demo: https://deploy-preview-119--showmychat.netlify.app/alerts/jacobbolda?DEMO=true
For PR Completion
I would be interested in opinions on the viability of this, and any possible issues with the current architecture. I suspect we want to do the css separate for the alert html than the chat. Presuming this is the case, help or pointers with the html and css would be ❤️ .