Adding html_support #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
Apr 11, 2024
rules/impl.bzl
Outdated
| outputs.append(html_output) | ||
|
|
||
| label = ctx.attr.android_home.label | ||
| if ctx.attr.android_home: |
There was a problem hiding this comment.
This doesn't look like its intended to be in this PR
EdbertChan
force-pushed
the
html_support
branch
from
bddd6d2
to
0768997
Compare
Bencodes
reviewed
Apr 12, 2024
rules/impl.bzl
Outdated
| @@ -63,7 +64,7 @@ def _run_android_lint( | |||
| android_lint_skip_bytecode_verifier: Disables bytecode verification | |||
| """ | |||
| inputs = [] | |||
| outputs = [output] | |||
| outputs = [output, html_output] | |||
There was a problem hiding this comment.
It would be great to support customizing the output format so that the user can pick which formats they want. Having to write them all out all the time also seems inefficient.
There was a problem hiding this comment.
Should we rename --output to --xml-output then to be explicit?
I'm thinking that we should flag it in the entrypoint .bzl:
html_output = True
xml_output = True
EdbertChan
force-pushed
the
html_support
branch
from
8bdf1ee
to
b71d87e
Compare
EdbertChan
force-pushed
the
html_support
branch
from
b71d87e
to
97ab9b8
Compare
|
These is a large refactor that involves renaming "output" to "xml_output" and "html_output" to distinguish the two. To invoke the output distinction, the api would look like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the htmlOutput flag for android lint