🐛 changed getter darkTheme to always return darkTheme and added getter lightTheme #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BirjuVachhani
requested changes
Apr 5, 2021
BirjuVachhani
added
bug
|
@bernhardfrenking Thanks for the PR. It will be available in the next release. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
adding an additional getter lightTheme and changing the getter darkTheme to always returning the dark theme instead of returning the current theme.
Alternate Designs
instead of the additional getter, the getter theme could alway return the lightTheme
Why Should This Be In Core?
mode independend getter for the modes are necesseray, if you need it for example in a theme settings screen
Benefits
usability improved in case of theme setting screens
Possible Drawbacks
not known
Verification Process
What process did you follow to verify that your change has the desired effects?
manually compared the themes from getter lightTheme and darkTheme
Applicable Issues
not known