Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): bump react-redux package #2879

Merged
merged 9 commits into from Jun 2, 2022

Conversation

pierregee
Copy link
Collaborator

@pierregee pierregee commented May 30, 2022

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

Upgrade to react-redux v8

React redux v8 upgrade key points:
Goal of react-redux v8 is to be compatible with React 18 (LW is currently using react v17.0.2)

References and other related discussions/announcements:

The only issue found on this upgrade is the infinite loop on the Feature Provider because of max retries which is fixed by using useEffect hook

Which issue(s) does this PR fixes?:

Fixes #2835

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wallet ✅ Ready (Inspect) Visit Preview Jun 1, 2022 at 8:26AM (UTC)

@github-actions github-actions bot added area/contexts kind/chore Non feature change labels May 30, 2022
@codeclimate
Copy link

codeclimate bot commented May 30, 2022

Code Climate has analyzed commit 7026d11 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented May 30, 2022

Deploy Preview for wallet-defichain ready!

Name Link
🔨 Latest commit 41fda4e
🔍 Latest deploy log https://app.netlify.com/sites/wallet-defichain/deploys/6296c2f84b0eef0009205638
😎 Deploy Preview https://deploy-preview-2879--wallet-defichain.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@defichain-bot
Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1154,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1154,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1154,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1154,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1154,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

@netlify
Copy link

netlify bot commented May 30, 2022

Deploy Preview for mobile-wallet-preview ready!

Name Link
🔨 Latest commit 7026d11
🔍 Latest deploy log https://app.netlify.com/sites/mobile-wallet-preview/deploys/629722993286f900082d0c79
😎 Deploy Preview https://deploy-preview-2879--mobile-wallet-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #2879 (7026d11) into main (9c4ea6d) will increase coverage by 3.99%.
The diff coverage is 84.78%.

@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
+ Coverage   81.23%   85.22%   +3.99%     
==========================================
  Files         365      366       +1     
  Lines        8197     8198       +1     
  Branches     2101     2101              
==========================================
+ Hits         6659     6987     +328     
+ Misses       1512     1201     -311     
+ Partials       26       10      -16     
Impacted Files Coverage Δ
mobile-app/app/hooks/useAddressBook.ts 100.00% <ø> (ø)
...tor/screens/Auctions/components/BrowseAuctions.tsx 0.00% <0.00%> (-97.73%) ⬇️
...vigator/screens/Auctions/components/ManageBids.tsx 0.00% <0.00%> (ø)
...avigator/screens/Auctions/hooks/SignBidAndSend.tsx 5.55% <0.00%> (-88.89%) ⬇️
...r/screens/Auctions/screens/AuctionDetailScreen.tsx 1.78% <0.00%> (-87.50%) ⬇️
...screens/Auctions/screens/ConfirmPlaceBidScreen.tsx 0.00% <0.00%> (-86.37%) ⬇️
...ens/Balances/components/BottomSheetAddressBook.tsx 0.00% <ø> (ø)
...s/Balances/components/BottomSheetAddressDetail.tsx 98.05% <ø> (+97.08%) ⬆️
...tor/screens/Balances/screens/AddressBookScreen.tsx 80.15% <ø> (ø)
...ator/screens/Balances/screens/FutureSwapScreen.tsx 96.96% <ø> (+96.96%) ⬆️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4ea6d...7026d11. Read the comment docs.

@cypress
Copy link

cypress bot commented May 30, 2022



Test summary

472 5 1 0


Run details

Project wallet
Status Failed
Commit b3d9538 ℹ️
Started Jun 1, 2022 8:29 AM
Ended Jun 1, 2022 9:01 AM
Duration 31:19 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


Failures

cypress/integration/functional/wallet/auctions/auctions.spec.ts Failed
1 Wallet - Auctions > Min. Next Bid > should display USD values in batch card
2 Wallet - Auctions > Min. Next Bid > should display USD values in quick bid bottom sheet in auction home screen
3 Wallet - Auctions > Min. Next Bid > should display USD values in place bid screen
4 Wallet - Auctions > Min. Next Bid > should display USD values in auction details screen
5 Wallet - Auctions > Min. Next Bid > should display USD values in quick bid bottom sheet in auction details screen

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thedoublejay
Copy link
Member

To add on React@18 update, we update react based on Expo support (and react-native in a way).

@defichain-bot
Copy link
Contributor

defichain-bot commented May 30, 2022

Build preview for DeFiChain Wallet is ready!

Built with commit b3d9538

https://expo.io/@defichain/wallet?release-channel=pr-preview-2879

Copy link
Member

@thedoublejay thedoublejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove @types/react-redux as it's already included on the main package

@vercel vercel bot temporarily deployed to Preview May 31, 2022 09:09 Inactive
@vercel vercel bot temporarily deployed to Preview May 31, 2022 09:11 Inactive
@vercel vercel bot temporarily deployed to Preview June 1, 2022 01:38 Inactive
@thedoublejay thedoublejay marked this pull request as ready for review June 1, 2022 07:49
@vercel vercel bot temporarily deployed to Preview June 1, 2022 07:50 Inactive
@pierregee pierregee requested a review from izzycsy as a code owner June 1, 2022 08:09
@vercel vercel bot temporarily deployed to Preview June 1, 2022 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview June 1, 2022 08:26 Inactive
@thedoublejay thedoublejay merged commit 5edb350 into main Jun 2, 2022
@thedoublejay thedoublejay deleted the pierregee/bump-react-redux-version branch June 2, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to react-redux@8.x.x
3 participants