Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/whale-api): support whale test suite for defid ocean #2177

Draft
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Jan 29, 2024

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Allow ocean test-suites running on Defid

Note for 2 tests (TODO(): multi defid support)

apps/whale-api/src/module.api/defid/loan.auction.history.defid
apps/whale-api/src/module.api/defid/loan.auction.controller.defid.ts

Additional comments?:

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit e2b678b
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/6655a1414857cc000873d2dc
😎 Deploy Preview https://deploy-preview-2177--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (767aa71) to head (a625e91).
Report is 1 commits behind head on main.

Current head a625e91 differs from pull request most recent head e2b678b

Please upload reports for the commit e2b678b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   89.38%   91.59%   +2.20%     
==========================================
  Files         374      374              
  Lines       11319    11319              
  Branches     1486     1486              
==========================================
+ Hits        10118    10368     +250     
+ Misses       1144      903     -241     
+ Partials       57       48       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canonbrother canonbrother force-pushed the canonbrother/whale-defid branch 4 times, most recently from e24bf44 to dc3722c Compare January 31, 2024 07:18
Copy link

github-actions bot commented Jan 31, 2024

Docker build preview for jellyfish/apps is ready!

Built with commit 07dd312

  • ghcr.io/birthdayresearch/legacy-api:pr-2177
  • ghcr.io/birthdayresearch/playground-api:pr-2177
  • ghcr.io/birthdayresearch/status-api:pr-2177
  • ghcr.io/birthdayresearch/whale-api:pr-2177

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:07dd31240a88bb707afccbecfb27d336d2d9ca56
  • ghcr.io/birthdayresearch/playground-api:07dd31240a88bb707afccbecfb27d336d2d9ca56
  • ghcr.io/birthdayresearch/status-api:07dd31240a88bb707afccbecfb27d336d2d9ca56
  • ghcr.io/birthdayresearch/whale-api:07dd31240a88bb707afccbecfb27d336d2d9ca56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant