-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: trying responsive font size #2699
base: master
Are you sure you want to change the base?
frontend: trying responsive font size #2699
Commits on May 9, 2024
-
frontend: remove unused css files
Seems as these files are not imported anywhere.
Configuration menu - View commit details
-
Copy full SHA for d654980 - Browse repository at this point
Copy the full SHA d654980View commit details -
Small cleanup: - import from same utils module - group imports from api - import styles last
Configuration menu - View commit details
-
Copy full SHA for c6aeea8 - Browse repository at this point
Copy the full SHA c6aeea8View commit details -
frontend: prepare for responsive font-size
In order to change the CSS to change the codebase to use rem, using 'The 62.5% Font Size Trick' we need to first convert all existing rem units back to px. This is so that we don't accidentally already have rem values. If the default base font size is 16px, 1rem equals 16px. Changing back to pixel first makes it much easier to use the 62.5% trick where 1rem = 10px. This refactoring should not introduce any visual change and just converted rem to px. I.e. 1.5rem is now 24px as 1rem currently equals 16px. Also simplified terms.module.css a bit as the title was defined multiple times.
Configuration menu - View commit details
-
Copy full SHA for f3420e7 - Browse repository at this point
Copy the full SHA f3420e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a886ad3 - Browse repository at this point
Copy the full SHA a886ad3View commit details -
frontend: andoird font size zoom can break the layout
Increasing the font size setting under 'Display size and text' on Android can break the layout in the WebView. There are 2 relevant settings: 'Font size' and 'Display size'. It appears that only the text is increased leaving the elements as if the font size was normal. Buttons look broken with text hanging out and transaction history is unreadable with overlapping text. This change seems to have no impact and was for testing purpose.
Configuration menu - View commit details
-
Copy full SHA for ee0c998 - Browse repository at this point
Copy the full SHA ee0c998View commit details -
frontend: trying text-size-adjust 100%
Last commit setting text-size-adjust to none seemed to have no impact on the breaking layout when font size is increased on in the os. Testing text-size-adjust 100%
Configuration menu - View commit details
-
Copy full SHA for 335955d - Browse repository at this point
Copy the full SHA 335955dView commit details -
frontend: trying responsive font size
This is a test to see if we can use responsive font size. This also sets the base font size so that 1rem is 10px (unless text zoom). With this technique elements can have responive dimension so that sizes using rem are also zoomed if the text font size is bigger.
Configuration menu - View commit details
-
Copy full SHA for 5aeeb8b - Browse repository at this point
Copy the full SHA 5aeeb8bView commit details -
frontend/android: capture textzoom and set custom base font size
Android textZoom only increases font-size without incresing surrounding elements which can break the layout and cause overlapping text and elements. This commit reads the current textzoom, sets a custom CSS base font size (calculated from textzoom) and resets textzoom to 100%. The custom CSS is using 'The 62.5% Font Size Trick' with which 1rem equals 10px. With this it is possible to change elment dimensions from px to rem. These elements will become responsive and also grow if Android settings for font size is increased. To simulate this in webdev and optimize the layout for increased fontsize a base font size of 125% has to be set.
Configuration menu - View commit details
-
Copy full SHA for df796db - Browse repository at this point
Copy the full SHA df796dbView commit details -
frontend: debug and display calculated base font and screen width
For debugging purpose this will render the calculated increased base font size and the screen width. The screen width can vary depending on Android display size setting.
Configuration menu - View commit details
-
Copy full SHA for b1b36ce - Browse repository at this point
Copy the full SHA b1b36ceView commit details -
frontend: style sidebar to be responsive
Sidebar does not need to grow, as it works well if the font size is renderd at 200%. Changing back to px.
Configuration menu - View commit details
-
Copy full SHA for 6d90bf6 - Browse repository at this point
Copy the full SHA 6d90bf6View commit details