Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint simple-import-sort plugin 💅💅💅 v2 #6589

Merged
merged 3 commits into from
May 21, 2024

Conversation

limpbrains
Copy link
Collaborator

@limpbrains limpbrains commented May 20, 2024

Same as #6321 but without adding new pluging to package.json

Copy link

socket-security bot commented May 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-plugin-react@7.34.1 filesystem Transitive: environment, eval +34 4.11 MB ljharb
npm/eslint@8.57.0 environment, filesystem Transitive: eval, shell, unsafe +43 9.56 MB eslintbot

🚮 Removed packages: npm/eslint-plugin-react@7.33.2, npm/eslint@8.56.0

View full report↗︎

@GladosBlueWallet
Copy link
Collaborator

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/j3hfkfvhwct3b6whxfx3p5eo3y?device=pixel4

download apk

@limpbrains limpbrains marked this pull request as ready for review May 20, 2024 13:04
@Overtorment
Copy link
Member

Overtorment commented May 20, 2024

image
kek

@limpbrains
Copy link
Collaborator Author

giphy2

Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. lets fix the conflict and merge

ps. maybe create npm script that installs the formatting dep, runs the formatter & uninstalls it? so we could run it from time to time

@GladosBlueWallet GladosBlueWallet merged commit 85f49b5 into master May 21, 2024
13 checks passed
@GladosBlueWallet GladosBlueWallet deleted the simple-import-sort branch May 21, 2024 11:45
@GladosBlueWallet
Copy link
Collaborator

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants