Remove default italic #1654
Remove default italic #1654
Conversation
This comment was marked as spam.
This comment was marked as spam.
|
That's a small change but with lots of consequences ^^ Running It will not ease our work at first, but then our rendering will be more identic to the Wiktionary itself. WDYT? |
|
Maybe better as a second pass ? Once we have stabilize here https://github.com/BoboTiG/ebook-reader-dict/blob/master/wikidict/lang/defaults.py#L102 we can go our way up in this function ? Or you prefer to have all of them at once ? Could be a bit discouraging ? |
|
For reference, I catched > 150 not supported templates in english. Most of them used 1 or 2 times in the whole dictionary... Already quite a lot of work. |
Clearly :) Let's delay such change, you 're right, we already have soo much to do. |
Also, if you prefer to commit big changes in one commit, go ahead. Creating issues is time consuming. |
| @@ -78,10 +78,6 @@ def last_template_handler( | |||
| text = parts[1] if len(parts) == 2 else word | |||
| return transliterate(lang, text) | |||
|
|
|||
| # {{tpl|item}} -> <i>(Templatet gf)</i> | |||
| if len(template) == 2: | |||
| return term(capitalize(lookup_italic(tpl, locale))) | |||
There was a problem hiding this comment.
I believe the best way would be to call lookup_italic(tpl, locale, True): here, just like above.
Then the template will be reported by the MISSING_TPL_SEEN code.
It will help us catch missing templates without
--check-word.