enable dark mode support for macOS mojave #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: you need to build the app with |
|
Just a little note for @lvarado - Thank you for this! Waiting for this to be merged and released. |
|
Awesome! Could you fix the conflicts? I'll merge this soon. |
|
Any update on this? |
|
@Rokt33r @ericsolomon got the conflicts resolved and cleaned up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dark mode support for macOS Mojave was added to
electron-packagerin 12.2.0:electron/packager#893
This PR updates
electron-packagerand adds the necessary config to the gruntfile.Before (dark mode enabled):
After:
Dark mode is automatically used when it is enabled in the system configuration:
Fixes #2417