Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comparing fork and upstream, added Imported category and fix bugs #1181

Merged
merged 17 commits into from
Dec 1, 2021
Merged

Improve comparing fork and upstream, added Imported category and fix bugs #1181

merged 17 commits into from
Dec 1, 2021

Conversation

cycool29
Copy link
Contributor

@cycool29 cycool29 commented Nov 17, 2021 •
edited

  • Use -b to specify a branch when git clone instead of check out branch after clone
  • Pull upstream repo before checking diff to avoid outdated app in fork listed as a modified app
  • Add imported app to Imported category
  • Remove category if no app in it
  • Added Imported category icon
  • Check Internet connection
  • Fix PR link not detected

@cycool29 cycool29 marked this pull request as draft November 17, 2021 05:47
@cycool29 cycool29 changed the title Use -b to specify branch when git clone, fetch and merge before diff (dont merge yet) Use -b to specify branch when git clone, fetch and merge before diff Nov 17, 2021
@cycool29 cycool29 marked this pull request as ready for review November 18, 2021 12:02
@cycool29 cycool29 changed the title (dont merge yet) Use -b to specify branch when git clone, fetch and merge before diff Use -b to specify branch when git clone, fetch and merge before diff Nov 18, 2021
@cycool29 cycool29 marked this pull request as draft November 18, 2021 14:41
@cycool29 cycool29 changed the title Use -b to specify branch when git clone, fetch and merge before diff (don't merge yet) Use -b to specify branch when git clone, fetch and merge before diff Nov 18, 2021
@cycool29 cycool29 marked this pull request as ready for review November 19, 2021 07:47
@cycool29 cycool29 changed the title (don't merge yet) Use -b to specify branch when git clone, fetch and merge before diff Improve comparing fork and upstream, added Imported category and fix bugs Nov 19, 2021
@cycool29
Copy link
Contributor Author

@Botspot

Botspot
Botspot reviewed Nov 19, 2021
View reviewed changes
api Outdated Show resolved Hide resolved
Botspot
Botspot reviewed Nov 21, 2021
View reviewed changes
api Outdated Show resolved Hide resolved
@Botspot Botspot merged commit 0d62a23 into Botspot:master Dec 1, 2021
@cycool29 cycool29 deleted the patch-1 branch December 2, 2021 06:14
@cycool29 cycool29 mentioned this pull request Dec 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Botspot Botspot Botspot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cycool29 @Botspot