add armcord application #1855

ryanfortner · 2022-05-22T19:51:43Z

No description provided.

theofficialgman · 2022-05-22T20:16:54Z

@ryanfortner converted to draft due to outdated armcord release build on electron 18.2.3 (or older 18.x.y) with bug preventing buster/bionic

ArmCord/ArmCord#117

Botspot · 2022-05-22T21:58:00Z

The install-32 script seems to be missing. I'm fairly sure ArmCord works on armhf.

ryanfortner · 2022-05-22T22:01:31Z

The install-32 script seems to be missing. I'm fairly ArmCord works on armhf.

There are no armhf binaries provided in releases currently, I could try compiling from source though. ArmCord/ArmCord#118

theofficialgman · 2022-05-31T19:53:40Z

I fixed releases upstream. a new 3.0.6 build is being made now. it will have armv7l debs as well. https://github.com/ArmCord/ArmCord/actions/runs/2417289145

just waiting on the dev to rename, make the tag, and publish

ryanfortner · 2022-05-31T20:23:00Z

Just bumped the version and added install-32. This should be good to go.

theofficialgman · 2022-05-31T20:48:59Z

tested on arm64 and the application works but the .desktop icon is missing...

it seems to have installed here:
/usr/share/icons/hicolor/0x0/apps/armcord.png

but it does not get used even after rebooting or reloading the cache

the 0x0 directory is very strange as well...

tracking here: ArmCord/ArmCord#128

theofficialgman · 2022-05-31T20:48:59Z

tested on arm64 and the application works but the .desktop icon is missing...

it seems to have installed here:
/usr/share/icons/hicolor/0x0/apps/armcord.png

but it does not get used even after rebooting or reloading the cache

the 0x0 directory is very strange as well...

Crilum · 2022-05-31T20:50:49Z

the 0x0 directory is very strange as well...

Yeah, never seen that before..

Crilum · 2022-05-31T20:54:14Z

Fails to install on armhf:

OS: Raspbian GNU/Linux 11 (bullseye)
OS architecture: 32-bit
Last updated Pi-Apps on: 05/31/2022
Latest Pi-Apps version: 05/31/2022
Kernel: aarch64 5.15.32-v8+
Device model: Raspberry Pi 4 Model B Rev 1.2
Cpu name: Cortex-A72
Ram size: 3.79 GB
Raspberry Pi OS image version: 2022-01-28
Language: en_US.UTF-8

BEGINNING OF LOG FILE:
-----------------------

nice: ‘/home/pi/pi-apps/apps/ArmCord/install-32’: No such file or directory

Failed to install ArmCord!
◢◣Need help? Copy the ENTIRE terminal output or take a screenshot.
Please ask on Github: https://github.com/Botspot/pi-apps/issues/new/choose
Or on Discord: https://discord.gg/RXSTvaUvuu

Kind of a weird error..
install-32 does exist.

Crilum · 2022-05-31T20:57:01Z

I think found the problem:

$ /home/pi/pi-apps/apps/ArmCord/install-32
bash: /home/pi/pi-apps/apps/ArmCord/install-32: /bin/bash^M: bad interpreter: No such file or directory

@ryanfortner It looks like you edited the script with a weird text editor..

theofficialgman · 2022-05-31T20:58:53Z

I changed the line ending to be LF, might work now. only the install-32 was CRLF

Crilum · 2022-05-31T20:59:42Z

Yeah, it works now. (The install script starts. I haven't tested the app yet)

theofficialgman · 2022-05-31T21:04:16Z

I notified upstream of the icon issue. appears to be an electron builder oversight or bug, they will try to fix tomorrow and then make another release. ArmCord/ArmCord#128

lets hold off on this a bit longer

ryanfortner · 2022-05-31T21:23:38Z

I think found the problem:
$ /home/pi/pi-apps/apps/ArmCord/install-32
bash: /home/pi/pi-apps/apps/ArmCord/install-32: /bin/bash^M: bad interpreter: No such file or directory
@ryanfortner It looks like you edited the script with a weird text editor..

That's odd, I was using the built-in github vscode editor...

Crilum · 2022-05-31T21:28:12Z

It's weird that the ArmCord icon is 1280x1280, yet it's in the 0x0 folder:

Crilum · 2022-05-31T21:31:34Z

I think found the problem:
$ /home/pi/pi-apps/apps/ArmCord/install-32
bash: /home/pi/pi-apps/apps/ArmCord/install-32: /bin/bash^M: bad interpreter: No such file or directory
@ryanfortner It looks like you edited the script with a weird text editor..
That's odd, I was using the built-in github vscode editor...

The one online? Maybe it expects you're using Windows (lol, probably not..), and that's just the default..

Crilum · 2022-05-31T21:48:32Z

I found the setting for it:

theofficialgman · 2022-06-01T20:59:07Z

upstream kept the same release number but the deb is fixed now

Botspot · 2022-06-06T14:53:01Z

I just tested this, and my only complaint is that the taskbar icon is unset, so it displays the generic "program" icon.
Last year, I asked SpacingBat3 how to set the icon in an Electron app, and he said to call BrowserWindow() with {icon: "/path/to/icon"}.
@smartFridge

theofficialgman · 2022-06-07T02:57:20Z

armcord does this already, I think the problem is the path is wrong for deb installs. that icon location doesn't exist https://github.com/ArmCord/ArmCord/blob/40d743d0e21e2b61659b9497ca4bb0e42b811b63/src/window.ts#L116-L147

theofficialgman · 2022-06-07T02:59:19Z

I just tested this, and my only complaint is that the taskbar icon is unset, so it displays the generic "program" icon. Last year, I asked SpacingBat3 how to set the icon in an Electron app, and he said to call BrowserWindow() with {icon: "/path/to/icon"}. @smartFridge

also btw, I don't have this problem. taskbar icon is correctly set

Crilum · 2022-06-07T17:03:54Z

@Botspot Which icon do you mean? The taskbar icon is correct, but the window icon is missing:

Botspot · 2022-06-07T17:45:57Z

@Botspot Which icon do you mean? The taskbar icon is correct, but the window icon is missing:

The system tray icon works for me, but the taskbar icon/program icon does not work.

also btw, I don't have this problem. taskbar icon is correctly set

@theofficialgman, that is to be expected on ~~Ubuntu~~ Gnome. Gnome DE uses the menu entry's icon if one is not set. I personally think this decision harmed the rest of the linux community, because it reduced the incentive to build apps correctly.
If worst comes to worst, it's possible to make a wrapper script with some xseticon magic like I did with Boxy SVG, but I'd rather it just be done right in the source code.

theofficialgman · 2022-06-07T18:00:41Z

@theofficialgman, that is to be expected on Ubuntu. Ubuntu DE uses the menu entry's icon if one is not set. I personally think this decision harmed the rest of the linux community, because it reduced the incentive to build apps right.

I assume you mean gnome (Ubuntu has no control over them) or unity. I was testing on budgie so I will have to check on lxde to see if that's the case

edit: confirmed, icon is missing in the taskbar in LXDE

smartfrigde · 2022-06-10T18:45:10Z

Seems to be fixed, I'll double check on other DEs tho. The fix will be on the dev branch which means it'll be either in newer release (which will take a while) or I can backport it to 3.0.6

Botspot · 2022-06-12T22:11:13Z

Seems to be fixed, I'll double check on other DEs tho. The fix will be on the dev branch which means it'll be either in newer release (which will take a while) or I can backport it to 3.0.6

@smartfrigde Whether you would rather wait or backport, it is up to you.
You can also say if you want ArmCord added to Pi-Apps before the program icon works correctly on Raspberry Pi OS. I wouldn't recommend this, but that's your choice.

Sussy-OS · 2022-06-15T22:24:15Z

I can't wait till this app comes! I mean, WebCord is good, but you cannot mod it like you can with ArmCord. 😄

Botspot · 2022-06-16T03:56:33Z

On a similar note to @Sussy-OS's comment, I recently noticed that WebCord's menubar no longer disappears when pressing the Alt key.

smartfrigde · 2022-06-17T15:53:54Z

v3.0.7 is ready with the icon fix ;)

theofficialgman · 2022-06-17T15:58:42Z

@smartfrigde sorry this can't be merged
electron's current 19 releases are broken on arm64 buster/bionic
https://github.com/ArmCord/ArmCord/blob/538bd1041292873356684eeaab13204076915c1f/package.json#L29

see: #1930

we are still waiting on 19.0.5 to release, the fix is already in the electron 19.x.y branch

smartfrigde · 2022-06-17T16:02:27Z

Once 19.0.5 releases I'll re-do the release and notify you here.

smartfrigde · 2022-06-21T11:30:30Z

Done.

theofficialgman · 2022-06-21T16:00:14Z

@Botspot merge whenever you get the chance to add the bitly links

Sussy-OS · 2022-06-21T18:50:38Z

I never knew bitly had an API until @Botspot started using it.

Sussy-OS · 2022-06-21T19:09:42Z

How is this open, yet ArmCord is added?
EDIT: My pi just updated that this is closed as I sent this.

add armcord application

b14a485

theofficialgman marked this pull request as draft May 22, 2022 20:16

theofficialgman added the Upstream Bug something isn't working that can only be fixed upstream label May 31, 2022

bump version to v3.0.6

226a46f

ryanfortner marked this pull request as ready for review May 31, 2022 20:19

add 32-bit script

a42135b

change line endings

95f568b

theofficialgman removed the Upstream Bug something isn't working that can only be fixed upstream label Jun 1, 2022

theofficialgman marked this pull request as draft June 17, 2022 15:57

bump to 3.0.7

795c8b7

theofficialgman marked this pull request as ready for review June 21, 2022 15:59

Botspot merged commit 5a5f2b5 into master Jun 21, 2022

Botspot deleted the ryanfortner-armcord branch June 21, 2022 19:15

add armcord application #1855

add armcord application #1855

Conversation

ryanfortner commented May 22, 2022

theofficialgman commented May 22, 2022 • edited

Botspot commented May 22, 2022 • edited

ryanfortner commented May 22, 2022

theofficialgman commented May 31, 2022

ryanfortner commented May 31, 2022

theofficialgman commented May 31, 2022 • edited

theofficialgman commented May 31, 2022

Crilum commented May 31, 2022

Crilum commented May 31, 2022 • edited

Crilum commented May 31, 2022

theofficialgman commented May 31, 2022 • edited

Crilum commented May 31, 2022 • edited

theofficialgman commented May 31, 2022 • edited

ryanfortner commented May 31, 2022 • edited

Crilum commented May 31, 2022

Crilum commented May 31, 2022

Crilum commented May 31, 2022

theofficialgman commented Jun 1, 2022

Botspot commented Jun 6, 2022

theofficialgman commented Jun 7, 2022

theofficialgman commented Jun 7, 2022

Crilum commented Jun 7, 2022

Botspot commented Jun 7, 2022 • edited

theofficialgman commented Jun 7, 2022 • edited

smartfrigde commented Jun 10, 2022 • edited

Botspot commented Jun 12, 2022

Sussy-OS commented Jun 15, 2022

Botspot commented Jun 16, 2022

smartfrigde commented Jun 17, 2022

theofficialgman commented Jun 17, 2022 • edited

smartfrigde commented Jun 17, 2022

smartfrigde commented Jun 21, 2022

theofficialgman commented Jun 21, 2022

Sussy-OS commented Jun 21, 2022

Sussy-OS commented Jun 21, 2022 • edited

theofficialgman commented May 22, 2022 •

edited

Botspot commented May 22, 2022 •

edited

theofficialgman commented May 31, 2022 •

edited

Crilum commented May 31, 2022 •

edited

theofficialgman commented May 31, 2022 •

edited

Crilum commented May 31, 2022 •

edited

theofficialgman commented May 31, 2022 •

edited

ryanfortner commented May 31, 2022 •

edited

Botspot commented Jun 7, 2022 •

edited

theofficialgman commented Jun 7, 2022 •

edited

smartfrigde commented Jun 10, 2022 •

edited

theofficialgman commented Jun 17, 2022 •

edited

Sussy-OS commented Jun 21, 2022 •

edited