Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for ng-html-bind directive handling #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix for ng-html-bind directive handling #13

wants to merge 3 commits into from

Conversation

myukselen
Copy link

There were two problems:

  • constant strings having "
  • ng-html-bind ternary regexp version matching beyond attribute boundary

@myukselen
fix(regexp): handle ng-html-bind constant string and ternary form
f0f3151 
when ng-html-bind includes a constant string with ", it was not converted to double quotes.

ng-html-bind ternary regex is hopefully fixed also
@myukselen
refactor(regexp): delete forgotten debug line
75d9a23 
In order to find erronous regexp, a debug log section was added. This removes it.
@review-ninja
Copy link

ReviewNinja

@myukselen
fix(interpolation): fixed escaped interpolation string handling
163459a 
Interpolation string should be escaped properly when used in an interpolation. This is handled in
HtmlFilterDoubleQuote and HtmlFilterSimpleQuote translationKey processing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myukselen @review-ninja